Thanks for all the answers, should be separated into different branches now so let's try again :)

*addon - script.extrafanartdownloader
*version - 0.4.0
*url - git://github.com/paddycarey/script.extrafanartdownloader.git <http://github.com/paddycarey/script.extrafanartdownloader.git>
*revision - 6cff0eff0b06d770242493daf1f602aa6b535861
*branch - stable
*xbmc version - eden-pre

Thanks,
Paddy

On 21/10/11 18:53, Zeljko Ametovic wrote:
I understand why you did it but with eden just around the corner I think we shouldnt be shipping dharma code unnecessarily.

if you could separate the code that would be great, or just wait for eden and have one branch :)

thx a lot!

amet

On Fri, Oct 21, 2011 at 9:36 PM, Patrick Carey <[email protected] <mailto:[email protected]>> wrote:

    The reason we did this was to lessen the maintenance burden on
    ourselves. As it is at the moment the script runs perfectly fine
    for me on both eden and dharma, although i didn't install from zip
    so maybe that's why i didn't run into the python version issue.

    If i just change the python version will it be acceptable for
    inclusion in dharma?

    If i need to seperate the version specific code into different
    branches i can certainly do that.

    Thanks,
    Paddy
    ----- Original message -----
    > Hi,
    >
    > since this is Eden version, why do we even have Dharma code in
    it, this
    > will never be able to run on Dharma builds due to the xbmc.python
    > version being 2.0.
    >
    > amet
    >
    > On Fri, Oct 21, 2011 at 3:09 AM, Patrick Carey
    <[email protected] <mailto:[email protected]>>
    > wrote:
    >
    > > This a major rewrite/update from the 0.3.7 version that's
    already in
    > > the repo so hopefully it still meets the standards.   If I've done
    > > anything wrong please let me know.
    > >
    > > *addon - script.extrafanartdownloader
    > > *version - 0.4.0
    > > *url -
    git://github.com/paddycarey/script.extrafanartdownloader.git
    <http://github.com/paddycarey/script.extrafanartdownloader.git>
    > > *revision - 1b1c08984b16e204e0d01332dab4e71e71234fb7
    > > *branch - stable
    > > *xbmc version - eden-pre
    > >
    > > Thanks,
    > > Paddy
    > >
    > >
    > >
    > >
    
------------------------------------------------------------------------------
    > > The demand for IT networking professionals continues to grow,
    and the
    > > demand for specialized networking skills is growing even more
    rapidly.
    > > Take a complimentary Learning@Cisco Self-Assessment and learn
    > > about Cisco certifications, training, and career opportunities.
    > > http://p.sf.net/sfu/cisco-dev2dev
    > > _______________________________________________
    > > Xbmc-addons mailing list
    > > [email protected]
    <mailto:[email protected]>
    > > https://lists.sourceforge.net/lists/listinfo/xbmc-addons
    > >



------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to