initial (short) review
Remove:
<minversion>31632</minversion>
No longer supported/needed
Add language tag
http://wiki.xbmc.org/index.php?title=Addon.xml#The_xbmc.addon.metadata_extension
in tester.py
Why do you use logging.warning as shutdown message? Isn't notice better?
Perhaps change the print statement to xbmc.log debug messages so they only
show up in debugging (to not flood the normal log)
This wass just some quick things i saw without going in the code to deep.
Perhaps beenje will have some other things.
Martijn
On Thu, Jan 31, 2013 at 7:00 AM, Bossanova808 <[email protected]>wrote:
> *addon - plugin.image.xzen
> *url - https://code.google.com/p/xzen-xbmc/****
>
> *version 0.0.7****
>
> *branch master****
>
> *revision =
> 7485f06812b4<https://code.google.com/p/xzen-xbmc/source/detail?r=7485f06812b4d9564b6ec5b2db83280a374d5889>
> ****
>
> *xbmc version = Frodo****
>
> * *
>
> Initial pull request for my plugin that is a ZenFolio browser (
> www.zenfolio.com). Uses their proper API so should be easy to maintain
> and I am happy to do so.****
>
> ** **
>
> Tested working on Windows and Openelec.****
>
> ** **
>
> (Probably works on Eden too but I no longer have any Eden machines, so
> can't test).****
>
> ** **
>
> ** **
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_d2d_jan
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
>
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
