Thanks again for the review.
All fixed - icon and fanart sizes, language tags added, dependency removed
as the module is supplied locally, minversion removed, tester.py removed
Should be good to go?
So - new revision:
*addon - plugin.image.xzen
*url - https://code.google.com/p/xzen-xbmc/
*version 0.0.7
*branch master
*NEW revision =
066461561af9
<https://code.google.com/p/xzen-xbmc/source/detail?r=066461561af9b032282ac67
ae1f7ecf5d41f95e7>
*xbmc version = Frodo
-----Original Message-----
From: Benjamin Bertrand [mailto:[email protected]]
Sent: Friday, 1 February 2013 9:02 AM
To: Martijn Kaijser
Cc: Bossanova808; [email protected]
Subject: Re: [Xbmc-addons] [Git Pull] plugin.image.xzen - 0.0.7 (Initial
pull request)
A few more comments:
1. The icon size must be 256x256 pixels
2. fanart should be 16:9 aspect ratio (we recommend a 1280x720 JPG image) 3.
script.module.b808common (0.0.4) is not in the xbmc repository, so
installation will fail. You have to submit this module for pull request.
Or include it in your addon as you did and remove the dependency from the
addon.xml.
4. As MArtin said, remove the minversion 5. As Martin said, add a language
tag
I guess tester.py is for testing purpose only and not run when using the
plugin.
/beenje
On Thu, Jan 31, 2013 at 8:13 AM, Martijn Kaijser <
<mailto:[email protected]> [email protected]> wrote:
> initial (short) review
>
> Remove:
>
> <minversion>31632</minversion>
>
> No longer supported/needed
> Add language tag
> <http://wiki.xbmc.org/index.php?title=Addon.xml#The_xbmc.addon.metadata>
http://wiki.xbmc.org/index.php?title=Addon.xml#The_xbmc.addon.metadata
> _extension
>
> in tester.py
> Why do you use logging.warning as shutdown message? Isn't notice better?
> Perhaps change the print statement to xbmc.log debug messages so they
> only show up in debugging (to not flood the normal log)
>
> This wass just some quick things i saw without going in the code to deep.
> Perhaps beenje will have some other things.
>
> Martijn
>
>
>
> On Thu, Jan 31, 2013 at 7:00 AM, Bossanova808 <
<mailto:[email protected]> [email protected]>
> wrote:
>>
>> *addon - plugin.image.xzen
>> *url - <https://code.google.com/p/xzen-xbmc/>
https://code.google.com/p/xzen-xbmc/
>>
>> *version 0.0.7
>>
>> *branch master
>>
>> *revision = 7485f06812b4
>>
>> *xbmc version = Frodo
>>
>>
>>
>> Initial pull request for my plugin that is a ZenFolio browser
>> ( <http://www.zenfolio.com> www.zenfolio.com). Uses their proper API so
should be easy to
>> maintain and I am happy to do so.
>>
>>
>>
>> Tested working on Windows and Openelec.
>>
>>
>>
>> (Probably works on Eden too but I no longer have any Eden machines,
>> so can't test).
>>
>>
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> --------- Everyone hates slow websites. So do we.
>> Make your web apps faster with AppDynamics Download AppDynamics Lite
>> for free today:
>> <http://p.sf.net/sfu/appdyn_d2d_jan> http://p.sf.net/sfu/appdyn_d2d_jan
>> _______________________________________________
>> Xbmc-addons mailing list
>> <mailto:[email protected]>
[email protected]
>> <https://lists.sourceforge.net/lists/listinfo/xbmc-addons>
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>
>
>
> ----------------------------------------------------------------------
> -------- Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics Download AppDynamics Lite
> for free today:
> <http://p.sf.net/sfu/appdyn_d2d_jan> http://p.sf.net/sfu/appdyn_d2d_jan
> _______________________________________________
> Xbmc-addons mailing list
> <mailto:[email protected]>
[email protected]
> <https://lists.sourceforge.net/lists/listinfo/xbmc-addons>
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
On Thu, Jan 31, 2013 at 8:13 AM, Martijn Kaijser <
<mailto:[email protected]> [email protected]> wrote:
> initial (short) review
>
> Remove:
>
> <minversion>31632</minversion>
>
> No longer supported/needed
> Add language tag
> <http://wiki.xbmc.org/index.php?title=Addon.xml#The_xbmc.addon.metadata>
http://wiki.xbmc.org/index.php?title=Addon.xml#The_xbmc.addon.metadata
> _extension
>
> in tester.py
> Why do you use logging.warning as shutdown message? Isn't notice better?
> Perhaps change the print statement to xbmc.log debug messages so they
> only show up in debugging (to not flood the normal log)
>
> This wass just some quick things i saw without going in the code to deep.
> Perhaps beenje will have some other things.
>
> Martijn
>
>
>
> On Thu, Jan 31, 2013 at 7:00 AM, Bossanova808 <
<mailto:[email protected]> [email protected]>
> wrote:
>>
>> *addon - plugin.image.xzen
>> *url - <https://code.google.com/p/xzen-xbmc/>
https://code.google.com/p/xzen-xbmc/
>>
>> *version 0.0.7
>>
>> *branch master
>>
>> *revision = 7485f06812b4
>>
>> *xbmc version = Frodo
>>
>>
>>
>> Initial pull request for my plugin that is a ZenFolio browser
>> ( <http://www.zenfolio.com> www.zenfolio.com). Uses their proper API so
should be easy to
>> maintain and I am happy to do so.
>>
>>
>>
>> Tested working on Windows and Openelec.
>>
>>
>>
>> (Probably works on Eden too but I no longer have any Eden machines,
>> so can't test).
>>
>>
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> --------- Everyone hates slow websites. So do we.
>> Make your web apps faster with AppDynamics Download AppDynamics Lite
>> for free today:
>> <http://p.sf.net/sfu/appdyn_d2d_jan> http://p.sf.net/sfu/appdyn_d2d_jan
>> _______________________________________________
>> Xbmc-addons mailing list
>> <mailto:[email protected]>
[email protected]
>> <https://lists.sourceforge.net/lists/listinfo/xbmc-addons>
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>
>
>
> ----------------------------------------------------------------------
> -------- Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics Download AppDynamics Lite
> for free today:
> <http://p.sf.net/sfu/appdyn_d2d_jan> http://p.sf.net/sfu/appdyn_d2d_jan
> _______________________________________________
> Xbmc-addons mailing list
> <mailto:[email protected]>
[email protected]
> <https://lists.sourceforge.net/lists/listinfo/xbmc-addons>
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
