On 20-02-14 11:59, Chris Bevan wrote: > Hi there. I'd like to have this skin considered for the official Frodo > repo please. > > *addon - skin.maximinimalism > *version - 1.0.0 > *url - https://github.com/chrisbevan/skin.maximinimalism > *revision - c61cfa84d741bdf4dfc845e8d80bcaf519cf115b > *branch - master > *xbmc version - frodo > > Cheers! > Chris. >
hi Chris, thanx for submitting your skin to the addon repo. it's always great to see one of the [wip] skins come to completion :) as with every first submission to the repo, it's gonna take a bit of effort to get everything into shape, but when the initial issues are all ironed out, subsequent updates should go easy as a breeze. i've taken maximinimalism for a test drive, and came up with a list of issues that need some attention: - screenshots in the _screenshots folder need to be 1280x720px - language strings should be in the 31xxx range (the 30xxx range, which you're also using, is reserved for plugins) - some case sensitive issues, please rename these files: ./colors/Defaults.xml -> ./colors/defaults.xml ./1080i/DialogSeekbar.xml -> ./1080i/DialogSeekBar.xml ./1080i/viewsPictures.xml -> ./1080i/ViewsPictures.xml ./1080i/includes_animations.xml -> ./1080i/Includes_animations.xml - please disable debuginfo by default (currently it's got the window name displayed on the screen) - these file have a BOM character at the start of the file, please remove the BOM: ./1080i/MusicOSD.xml ./1080i/DialogContextMenu.xml ./1080i/DialogSeekbar.xml ./1080i/DialogProgress.xml ./1080i/DialogYesNo.xml ./1080i/Startup.xml ./1080i/DialogOk.xml ./1080i/DialogNetworkSetup.xml - xml validation fails for these files: ./1080i/MyVideoNav.xml:793.65: EntityRef: expecting ';' <onclick>RunScript(script.globalsearch,movies=true&tvshows=true&episodes=t ./1080i/MyMusicPlaylist.xml:489.65: EntityRef: expecting ';' <onclick>RunScript(script.globalsearch,artists=true&albums=true)</onclick> ./1080i/MyMusicNav.xml:752.65: EntityRef: expecting ';' <onclick>RunScript(script.globalsearch,artists=true&albums=true)</onclick> ./1080i/MyMusicSongs.xml:514.65: EntityRef: expecting ';' <onclick>RunScript(script.globalsearch,artists=true&albums=true)</onclick> use & instead of & ./1080i/DialogNumeric.xml:129.5: StartTag: invalid element name <--row 2--> ./1080i/script-globalsearch-main.xml:602.7: StartTag: invalid element name <--found episodes--> xml comments should start with <!-- - these files need to be converted to unix style EOL's: 1080i/DialogKaraokeSongSelector.xml: Windows (CRLF) 1080i/DialogKaraokeSongSelectorLarge.xml: Windows (CRLF) 1080i/DialogTextViewer.xml: Windows (CRLF) 1080i/MusicKaraokeLyrics.xml: Windows (CRLF) 1080i/SlideShow.xml: Windows (CRLF) 1080i/SmartPlaylistEditor.xml: Windows (CRLF) 1080i/SmartPlaylistRule.xml: Windows (CRLF) fonts/sourceSansPro/license.txt: Windows (CRLF) LICENSE.txt: Windows (CRLF) - the use of '-' in onclick is not valid, please use <onclick>noop</onclick> in the following files: 1080i/MyWeather.xml 1080i/MyPVR.xml 1080i/SettingsSystemInfo.xml - the same applies to <onleft>, used in this file: 1080i/MyMusicPlaylistEditor.xml - these files are marked as executable, please remove the executable bit: ./fonts/sourceSansPro/license.txt ./fonts/symbol.ttf - undefined Vars: itemdetail ViewsVideos.xml (2x) - unmatched parenthesis in Includes_variables.xml: Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),video) + isempty(Skin.String(customVideoAddon1) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),video) + isempty(Skin.String(customVideoAddon2) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),video) + isempty(Skin.String(customVideoAddon3) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),video) + isempty(Skin.String(customVideoAddon4) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),video) + isempty(Skin.String(customVideoAddon5) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),video) + isempty(Skin.String(customVideoAddon6) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),video) + isempty(Skin.String(customVideoAddon7) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),video) + isempty(Skin.String(customVideoAddon8) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),audio) + isempty(Skin.String(customMusicAddon1) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),audio) + isempty(Skin.String(customMusicAddon2) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),audio) + isempty(Skin.String(customMusicAddon3) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),audio) + isempty(Skin.String(customMusicAddon4) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),audio) + isempty(Skin.String(customMusicAddon5) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),audio) + isempty(Skin.String(customMusicAddon6) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),audio) + isempty(Skin.String(customMusicAddon7) Unmatched parenthesis: stringcompare(Skin.String(menuItemTypeFilter),audio) + isempty(Skin.String(customMusicAddon8) - mandatory xml files missing (they're empty): DialogSongInfo.xml DialogFileStacking.xml MyVideoPlaylist.xml VisualisationPresetList.xml MusicOSD.xml script-globalsearch-contextmenu.xml (either remove this one, or include a functional one) - missing player controls both VideoOSD.xml as well as MusicOSD.xml need a set of stop/play/pause/next/etc.. buttons not everyone uses a fullblown remote, users who are using simple 8-button remote can't control playback atm. - skins should not interfere with music or video playback, i noticed your in skin: video playback stops when exiting fullscreen music playback stops when entering pictures (there may be others...) - livetv - could be me, but i can't find the radio channels list? - remove this file: MyVideo.xml (it's not used anymore in frodo) - remove the <defaultcontrol> definition in DialogKaiToast.xml (there's no focusable control in this dialog) - one error i found in the log while running the skin: 00:17:59 T:140441358894976 ERROR: Keymapping error: no such action 'container.setviewmode()' defined 00:17:59 T:140441358894976 DEBUG: ExecuteXBMCAction : Tried translating, but failed to understand Container.SetViewMode($VAR[videoViewType]) i'm not 100% sure, but i guess you can't use a $VAR[] inside the container.setviewmode() action. probably only integers are supported there. if anything is unclear, or if you need help, please don't hesitate to ask! cheers, ronie ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
