On 06-04-14 22:36, Chris Bevan wrote:
> Hi there. I'd like to have this skin reconsidered for the official Gotham
> repo please.
>
> *addon - skin.maximinimalism
> *version - 1.0.0
> *url - https://github.com/chrisbevan/skin.maximinimalism
> *revision - 64b00f4775a98a4537bf16cc073e5834daab6a78
> *branch - master
> *xbmc version - gotham
>
> Cheers,
> Chris.
>

hey Chris,

thanx for all the adjustments so far, you pretty much nailed them all.
there's a few minor niggles left to address:

addon.xml
add a language tag to summary / description:
<summary lang="en">...


remove this file, it's no longer used in gotham:
script-XBMC-Subtitles-main.xml


SCRIPTXXX labels are no longer supported in gotham
DialogSubtitles.xml: <label>$LOCALIZE[SCRIPT655]</label>
http://forum.xbmc.org/showthread.php?tid=158812&pid=1521488#pid1521488


most of the xml files are marked as executable, please remove the 
executable bit


as metioned before, skins should not interfere with media playback.
please leave it up to the user to stop video playback and don't override 
this from within the skin.


cheers,
ronie

------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to