Hi All,
Just to cover the two addon's in my areas:
TvTunes:
The requests package is currently used for getting TV/Movie themes from
Grooveshark and Soundcloud websites (televisiontunes.com and goear.com
are not affected). So if this was to be published and was incompatible
with these bits - it would just impact users when they tried to download
a theme for an new addition in their library - and only if they use one
of these two sites).
Sonos:
The requests is used to communicate with the Sonos Speaker - so if a
requests change breaks this one - nothing will work - However I think it
may actually be OK with the latest requests version.
So from my point of view, although I have no need for this to be
upgraded - I do understand how frustrating it can be needing something
in a more recent version, so I'm happy for it to be upgraded and if
some-one can let me have a "pre-release" copy of the updated requests
module, then I'll run a couple of tests - or even better, post onto the
forums so that several users could verify - the TvTunes forum has lots
of helpful users that I'm sure would give it a good test and feedback
the results. (BTW: I'm for updating the existing rather than having a
new module added).
I know very late in the day now, but maybe a sort of OSGi-like
versioning system could be added in future, where for "module" addons,
there is a version of major.minor.mico so that changing the major
version highlights an incompatible API change, then users could import
them into their own product something like:
<import addon="script.module.requests" version="1.1.0"
match="latest"/>
To get the latest version, regardless of API change, so if there were a
2.0.0 - it would get that
<import addon="script.module.requests" version="1.1.0"
match="compatible"/>
To get the latest version for major version "1" (with 1.1.0 being the
minimum version that can be used) - in this case 2.0.0 would not be used
<import addon="script.module.requests" version="1.1.0"
match="perfect"/>
To force the use of an exact version
You could then default
<import addon="script.module.requests" version="1.1.0"/>
To one of these - maybe latest?
This way this sort of issue could be avoided in future? - However, I
guess this would bring it's own challenges!
Rob
On 02/08/2014 13:12, Thomas Amland wrote:
> cc
>
> On Sat, Aug 2, 2014 at 12:59 PM, Thomas Amland <[email protected]>
> wrote:
>> On Fri, Aug 1, 2014 at 11:53 PM, Benjamin BERTRAND <[email protected]> wrote:
>>>
>>> That’s nice that you want to help.
>>> I did a grep in the repo and here are the plugins and scripts using
>>> requests (I removed my add ons):
>>
>> Ok, here's my result. I just greped the whole repo too as it was much
>> easier:
>>
>> Only use get/post etc.
>> plugin.audio.abcradionational
>> plugin.audio.jambmc
>> plugin.audio.qobuz
>>
>> plugin.video.classiccinema
>> plugin.video.filmarkivet
>> plugin.video.khanacademy
>> plugin.video.newyorktimes
>> plugin.video.noco
>> plugin.video.nrk
>> plugin.video.redditmusic
>> plugin.video.rsa
>> plugin.video.the.daily.show
>> plugin.video.the.colbert.report
>> plugin.video.udacity
>> plugin.video.xbmb3c
>> script.sonos
>> script.tvrage.com
>> script.xbmc.subtitles
>>
>>
>> Use requests2, not requests
>> plugin.video.oodnurdtv
>> script.artistslideshow
>>
>>
>> Extensive API usage, hard to check:
>> plugin.video.cessfull
>> plugin.video.putio
>> plugin.video.putiov2
>> script.tvtunes
>>
>>
>> Use timeout (behavior change)
>> plugin.video.theberrics
>> plugin.video.thrasherskateboard
>>
>>
>> Only the last 6 add-ons are possibly affected.
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
