Great! Are we good for update then. Benjamin?
On Sun, Aug 17, 2014 at 9:39 AM, Robert Hudson <[email protected]> wrote: > > OK, I have verified the Sonos addon, and that works fine with the new > requests module. > > capfuturo has also confirmed that it works with TVTunes. > > Rob > > > > > On 14/08/2014 11:12, Thomas Amland wrote: >> >> Aren't you the maintainer of the add-on? It would be better to have >> confirmation from the maintainer that it's ok to update. You can read >> the API changes here: >> >> http://docs.python-requests.org/en/latest/api/#migrating-to-2-x >> >> The main problem is that the add-ons use elaborate hacks around >> requests, so it's hard for me who doesn't know the code to immediately >> see. I would be surprised if those minor changes break anything >> though. >> >> >> >> On Mon, Aug 11, 2014 at 7:23 PM, Robert Hudson <[email protected]> wrote: >>> >>> Sorry, >>> >>> I haven't had a chance to check this out yet. >>> >>> Please can you post a request on the TvTunes forum - and maybe ask if >>> this >>> is something that capfuturo and/or wgstarks can assist with testing for >>> TvTunes (They are normally very helpful) >>> >>> I should hopefully be able to get time to test the Sonos one sometime >>> soon. >>> >>> Rob >>> >>> >>> >>> >>> On 11/08/2014 14:55, Thomas Amland wrote: >>>> >>>> Any progress Rob? >>>> >>>> I have already manually tested theberrics and thrasherskateboard and >>>> they are not affected. (thrasherskateboard is current broken btw). >>>> cessfull, putio and putiov2 require login so I cannot test. If it's ok >>>> to ignore those less used plugins, only sonos and tvtune are left to >>>> test. >>>> >>>> >>>> >>>> On Tue, Aug 5, 2014 at 10:48 PM, Benjamin BERTRAND <[email protected]> >>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>>> Hi All, >>>>>> >>>>>> Just to cover the two addon's in my areas: >>>>>> >>>>>> TvTunes: >>>>>> The requests package is currently used for getting TV/Movie themes >>>>>> from >>>>>> Grooveshark and Soundcloud websites (televisiontunes.com and goear.com >>>>>> are not affected). So if this was to be published and was >>>>>> incompatible >>>>>> with these bits - it would just impact users when they tried to >>>>>> download >>>>>> a theme for an new addition in their library - and only if they use >>>>>> one >>>>>> of these two sites). >>>>>> >>>>>> Sonos: >>>>>> The requests is used to communicate with the Sonos Speaker - so if a >>>>>> requests change breaks this one - nothing will work - However I think >>>>>> it >>>>>> may actually be OK with the latest requests version. >>>>>> >>>>>> >>>>>> So from my point of view, although I have no need for this to be >>>>>> upgraded - I do understand how frustrating it can be needing something >>>>>> in a more recent version, so I'm happy for it to be upgraded and if >>>>>> some-one can let me have a "pre-release" copy of the updated requests >>>>>> module, then I'll run a couple of tests - or even better, post onto >>>>>> the >>>>>> forums so that several users could verify - the TvTunes forum has lots >>>>>> of helpful users that I'm sure would give it a good test and feedback >>>>>> the results. (BTW: I'm for updating the existing rather than having a >>>>>> new module added). >>>>>> >>>>> I just pushed to my repo version 2.3.0: >>>>> https://github.com/beenje/script.module.requests >>>>> Branch: frodo >>>>> Tag: v2.3.0 >>>>> >>>>> You can download a zip from github, but you’ll have to rename the root >>>>> directory from script.module.requests-2.3.0 to script.module.requests. >>>>> I can send you a proper zip if you prefer. >>>>> Would be great if you can test with your addons. >>>>> >>>>> Thanks >>>>> >>>>> /Benjamin >>> >>> > ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
