Hi Ronie,
Thanks for your reply, will send the requests to the mailing list, sorry about
that.
I fixed the mentioned issues.
Concerned the invalid includes: those files do exist and are valid.
I do Always perform tests with the "skin XML convertor" tool.
Maybe something was wrong with the zip file ?
I've updated the zip files on the download location.
Do you want me to create a separate request for the helper script or is it fine
for now and I'll have to do that on updates ?
The download-locations:
1. The helper script: script.titanskin.helpers
Download à http://marcel-rosmalen.no-ip.org/script.titanskin.helpers.zip
2. The skin itself: skin.titan
Download à http://marcel-rosmalen.no-ip.org/skin.titan.zip
I also have SVN-access. For next time, is that easier for you ?
Kind regards,
Marcel
Date: Tue, 2 Sep 2014 13:55:40 +0200
From: [email protected]
To: [email protected]; [email protected]
Subject: Re: [Xbmc-addons] [Zip Pull] Titan MediaBrowser skin
hey Marcel,
please make sure you send all pull requests to the addon mailing
list and *not* to me personally ;-)
also, in the future, please send a separate pull request for the
scripts, as those will be reviewed by someone else.
there's a few issues left to address:
- the latest zipfile has no images in the media folder.
please remove the .xbt files and re-add the images.
- IncludesVariables.xml:
Unmatched parenthesis: !Skin.HasTheme(classic) +
[StringCompare(ListItem.Overlay,OverlayWatched.png)
Unmatched parenthesis: Skin.HasTheme(classic) +
[StringCompare(ListItem.Overlay,OverlayWatched.png)
- invalid includes, please remove those lines from includes.xml:
<include file="Custom_MediaDialog.xml" />
<include file="MyPVR.xml" />
- case sensitive issue:
rename the folder skin.titan/extras/weather/NA to
skin.titan/extras/weather/na
cheers,
ronie
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
