don't use
<import addon="xbmc.addon" version="12.9.10"/>
please add most/all of
http://wiki.xbmc.org/index.php?title=addon.xml#Required_elements (also in
the skin if possible)
instead of print you can also use
http://mirrors.xbmc.org/docs/python-docs/13.0-gotham/xbmc.html#-log
you never actually check if plugin.video.xbmb3c is installed.
why do you have <import addon="script.module.simplejson" version="3.3.0"/>
if you don't use it?
regards,
Martijn Kaijser
XBMC Foundation
On 2 September 2014 19:29, Marcel van der Veldt <[email protected]>
wrote:
> Hi Ronie,
>
>
>
> Thanks for the explanation, makes a lot of sense now ;-)
>
> Also thanks for forwarding the script to Martijn.
>
>
>
> I made the last changes and here’s the SVN link:
>
>
>
> https://subversion.assembla.com/svn/xbmc-skin-titan/trunk/skin.titan/
>
>
>
> Thanks!
>
>
>
> Marcel
>
>
>
>
>
> *Van:* ronie [mailto:[email protected]]
> *Verzonden:* dinsdag 2 september 2014 19:12
> *Aan:* Marcel van der Veldt; [email protected]
> *Onderwerp:* Re: [Xbmc-addons] [Zip Pull] Titan MediaBrowser skin
>
>
>
> On 02-09-14 14:54, Marcel van der Veldt wrote:
>
> Hi Ronie,
>
> Thanks for your reply, will send the requests to the mailing list, sorry
> about that.
>
> I fixed the mentioned issues.
> Concerned the invalid includes: those files do exist and are valid.
> I do Always perform tests with the "skin XML convertor" tool.
>
> Maybe something was wrong with the zip file ?
>
> I've updated the zip files on the download location.
> Do you want me to create a separate request for the helper script or is it
> fine for now and I'll have to do that on updates ?
>
> The download-locations:
>
> 1. The helper script: script.titanskin.helpers
> Download à http://marcel-rosmalen.no-ip.org/script.titanskin.helpers.zip
>
> 2. The skin itself: skin.titan
> Download à http://marcel-rosmalen.no-ip.org/skin.titan.zip
>
>
> I also have SVN-access. For next time, is that easier for you ?
>
> Kind regards,
>
> Marcel
>
>
> hey Marcel,
>
> you don't have to include windows/dialogs in includes.xml.
> just as you're not including, for instance, MyVideoNav.xml,
> you also should not include MyPVR.xml or Custom_MediaDialog.xml.
>
> hope that makes sense :-)
>
> good to hear the skin xml tool, it's my favourite peace of software to
> check for skin bugs.
> while it doesn't catch the issue above, it does lead to errors in your
> logfile.
>
> anyway, if you could please fix this remaining issue, then i'm ready to
> add your skin to the repo
> as soon as the scripts are excepted as well.
>
>
> i've forwarded your email to Martijn, who handles script pulls, so no need
> to send separate request this time.
> ... and yes, svn will be much easier for me ;-)
>
>
> cheers,
> ronie
>
>
> ------------------------------------------------------------------------------
> Slashdot TV.
> Video for Nerds. Stuff that matters.
> http://tv.slashdot.org/
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
>
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
