Den 16-04-2012 13:30, Byrial Jensen skrev:
Den 16-04-2012 09:03, h.g. muller skrev:
At 14:35 15-4-2012 -0700, Arun Persaud wrote:
Hi
how about enabling "-Wall -Wno-parentheses" on master and v4.6.x? You
can test the output of this by running
make CFlAGS="-Wall -Wno-parentheses"
ARUN
That seems a bad idea, because it would just flood us with warnings
which
I am dead against fixing, because it wouldmake the code unreadable.
I just removed the 9 warnings of type unused-but-set-variable and the
2 warnings of type unused-function that would be enabled by Arun's
proposal in the master branch. I totally cannot see how these removals
make the code more unreadable.
PS. It may be a good idea to check if the removals of unused variables
and functions are correct. Maybe some the variables or functions should
have been used for correct behavior of the program. If that was the
case, the warnings were indeed useful to discover the error.
