HI Chris, A nice catch, I wrote the code a while ago, maybe I got confused by the return value of xCAT::Utils->isSELINUX() when I wrote the code, the xCAT::Utils->isSELINUX() simply returns the return value from command selinuxenabled, the selinuxenabled command return value 0 means SELinux is enabled and 1 means SELinux is not enabled, it is a little bit different with the common sense, I should have checked the code more carefully -:(
Please open a bug and assign it to me(sourceforge id ligc), I will fix it right away, thanks. ------------------------------------------------------------------------- Li,Guang Cheng (李光成) IBM China System Technology Laboratory Email: [email protected] Address: Building 28, ZhongGuanCun Software Park, No.8, Dong Bei Wang West Road, Haidian District Beijing 100193, PRC 北京市海淀区东北旺西路8号中关村软件园28号楼 邮编: 100193 From: Christopher Samuel <[email protected]> To: [email protected] Date: 2013-04-15 09:39 Subject: Re: [xcat-user] Is xCAT 2.8 meant to disable SELinux? -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 14/04/13 05:52, Bruce M Potter wrote: > my $rc=xCAT::Utils->isSELINUX(); if ($rc != 0) I think this is the bug: isSELINUX() returns 0 if it's enabled so the check to say its enabled and then disable it should be for 0, not for !=0.. I'll open a bug now. cheers! Chris - -- Christopher Samuel Senior Systems Administrator VLSCI - Victorian Life Sciences Computation Initiative Email: [email protected] Phone: +61 (0)3 903 55545 http://www.vlsci.org.au/ http://twitter.com/vlsci -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlFrWjEACgkQO2KABBYQAh8iNwCfSp9XTgbC1jXAVfTkmlb0EfOh 67sAoIfc4cXkwuknSgM1+f4RL5SD0Frv =v4FO -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ xCAT-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xcat-user
<<inline: graycol.gif>>
------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________ xCAT-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xcat-user
