I don't like the fact that there is a maximum number of entries allowed in a conf file. I am not sure what the format of ld.so.conf file is, but I would guess that it allows # comments at the end of lines even if they specify a library path.

It looks like it is possible to write over the last element of the ret array (if (n>maxentries) breaks the loop and then ret[n] = NULL writes outside of its boundaries).

I don't think it is a good idea of having FILE * passed to a function that at the end closes the file. Who opens the file should take care of closing it.

Thanks,
        Lucho

On Sep 10, 2008, at 3:02 PM, Abhishek Kulkarni wrote:

xp_ldd can now read from ld.so.conf for additional library paths.
It also supports the new ld.so.conf file format with the 'include'
directive.

Signed-off-by: Abhishek Kulkarni <[EMAIL PROTECTED]>
<all.patch>

Reply via email to