Acked-by: Latchesar Ionkov <[EMAIL PROTECTED]>
On Sep 11, 2008, at 1:33 PM, Abhishek Kulkarni wrote:
Fixed a memory corruption issue, and an erroneous free. Signed-off-by: Abhishek Kulkarni <[EMAIL PROTECTED]> On Thu, 2008-09-11 at 11:12 -0600, Abhishek Kulkarni wrote:Lucho, thanks for the review. On Wed, Sep 10, 2008 at 3:59 PM, Latchesar Ionkov <[EMAIL PROTECTED]> wrote: I don't like the fact that there is a maximum number of entries allowed in a conf file. I am not sure what the format of ld.so.conf file is, but I would guess that it allows # comments at the end of lines even if they specify a library path.There is no limit on the maximum number of entries now. You are right,ldconfig allows # comments at the end of the line too. That should work now. It looks like it is possible to write over the last element of the ret array (if (n>maxentries) breaks the loop and then ret[n] = NULL writes outside of its boundaries). I don't think it is a good idea of having FILE * passed to a function that at the end closes the file. Who opens the file should take care of closing it. Fixed. I also removed the _GNU_SOURCE define here. Thanks, -- Abhishek Thanks, Lucho On Sep 10, 2008, at 3:02 PM, Abhishek Kulkarni wrote: xp_ldd can now read from ld.so.conf for additional library paths. It also supports the new ld.so.conf file format with the 'include' directive. Signed-off-by: Abhishek Kulkarni <[EMAIL PROTECTED]> <all.patch><all.patch>
