On Sat, Dec 13, 2008 at 9:37 PM, Daniel Gruner <[email protected]> wrote:
> > Hi Abhishek, > > What is the status of your port of bjs? Is it part of the sxcpu tree > (or pulled when one checks out from the sxcpu svn repository)? I'd > really like to test it... > Daniel, You probably missed the quick announcement, here it is again: http://groups.google.com/group/xcpu/browse_thread/thread/42ed613c72fe55ba# After syncing changes between the sxcpu and the xcpu2 tree, it could be used for either. Let me know how it works for you. Thanks > > Daniel > > > On Mon, Dec 8, 2008 at 3:08 PM, Abhishek Kulkarni <[email protected]> > wrote: > > > > This patch makes bjs comply with the changed semantics of > > xp_nodeset_list_by_state to obtain the down nodes from statfs. > > > > Signed-off-by: Abhishek Kulkarni <[email protected]> > > > > Index: bjs.c > > =================================================================== > > --- bjs.c (revision 746) > > +++ bjs.c (working copy) > > @@ -2481,19 +2481,7 @@ > > > > if (r > 0) { > > /* Check for machine status changes */ > > - /* TODO: Instead of jumping over these hoops, improve the > > - way down nodes can be obtained from statfs */ > > - > > - down_nodeset = xp_nodeset_list_by_state(conf.statfsaddr, > > "down(initializing)"); > > - xp_nodeset_append(down_nodeset, > > - xp_nodeset_list_by_state(conf.statfsaddr, > > "down(disconnected)")); > > - xp_nodeset_append(down_nodeset, > > - xp_nodeset_list_by_state(conf.statfsaddr, > > "down(connect_failed)")); > > - xp_nodeset_append(down_nodeset, > > - xp_nodeset_list_by_state(conf.statfsaddr, > > "down(read_failed)")); > > - xp_nodeset_append(down_nodeset, > > - xp_nodeset_list_by_state(conf.statfsaddr, > > "down(no_contact)")); > > - > > + down_nodeset = xp_nodeset_list_by_state(conf.statfsaddr, 0); > > if (down_nodeset->len != down_nodes) { > > if (verbose) syslog(LOG_INFO, "XCPU cluster status > change."); > > chng = update_cluster_status(conf.statfsaddr); > > @@ -2505,9 +2493,10 @@ > > p->policy->state_change(p); > > } > > } > > + down_nodes = down_nodeset->len; > > } > > - down_nodes = down_nodeset->len; > > > > + > > /* Check for new clients */ > > if (FD_ISSET(conf.client_sockfd, &rset)) > > client_accept(); > > > > > > >
