>Looked more at the code and
>found out that the dtd has to be changed in two places: jboss.j and the
>static variable JBOSS_DTD_FILE_NAME_30 of the JBossSubTask class.

Two places?  Surely we can do better than that :-)  Perhaps not for the 
filenames, but certainly for the public ID we could have a tag that 
returns the ID appropriate to the Version value?  Come to think of it, 
it's probably worth including the remote paths in the subtask and adding 
another tag for them too.  Then the strings are all in the one place so 
maintenance is easier, and we can eliminate the
<XDtConfig:ifConfigParamEquals paramName="Version" value="x.x">
bits from the template.

I'd have a try at it myself tomorrow, but since I don't use JBoss testing 
my changes (beyond just checking the samples' output is the same) would be 
a bit awkward...

I guess similar tags would be useful anywhere else we've got a DTD 
mentioned in both a template and the corresponding SubTask, but I can't 
think of a way to do a more general template tag for including arbitrary 
string constants' values, other than using reflection maybe.


Andrew.

_______________________________________________
Xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to