> >Looked more at the code and > >found out that the dtd has to be changed in two places: jboss.j and the > >static variable JBOSS_DTD_FILE_NAME_30 of the JBossSubTask class. > > Two places? Surely we can do better than that :-) Perhaps not for the > filenames, but certainly for the public ID we could have a tag that > returns the ID appropriate to the Version value? Come to think of it, > it's probably worth including the remote paths in the subtask and adding > another tag for them too. Then the strings are all in the one place so > maintenance is easier, and we can eliminate the > <XDtConfig:ifConfigParamEquals paramName="Version" value="x.x"> > bits from the template. > > I'd have a try at it myself tomorrow, but since I don't use JBoss testing > my changes (beyond just checking the samples' output is the same) would be > a bit awkward...
Good idea. Create a new namespace, say XDtXml and define a dtdEntry() or something like that there, this one with look back at getActiveSubTask(), cast it to XmlSubTask and call a new getDtdEntry() method on it. That method can check current template file and settings (jboss version/etc) and return the correct dtd entry/publicid. Ara. _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com _______________________________________________ Xdoclet-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
