On Thu, 31 Jan 2002, Dmitri Colebatch wrote:
> From: "David Budworth" <[EMAIL PROTECTED]>
>
> > But that's not what my point was. It was more of, do we take the
> > valid_values and split them. Or do what it's doing now, which is take
> > the field value and index into valid_values.
>
> ok, so int he templates, where its typically specified comma-delimited, we'd leave
>that the same, but as soon as its parsed into a
> String[] it stays as stuch?
Totally agree. I was so not thinking of templates when I said that.
Might was well tokenize on every pass so the code doesn't have to be
smart and check if it's already been converted.
>
> > But now, an aditional issue. Do we split up the tag value also? I don't
> > think we should. Is there any case where we allow multiple values for
> > the same tag? (ie view-type="local,remote") (yes i know this doesn't
> > work. it's just an example)
>
> well atm that is used in ejb:interface-method. but as discussed, is avoidable.
Ok, well with my latest checkings, it is no longer useable there.
If it's REQUIRED by some template. I'll roll back my change. The
samples compile fine with it though.
> cheers
> dim
>
> >
> > -David
> >
> > On Thu, 31 Jan 2002, Dmitri Colebatch wrote:
> >
> > > I was noticing this the other day. in InterfaceTagsHandler.isInterfaceMethod we
>have
> > >
> > > if( "both".equals( viewType ) )
> > > {
> > > viewType = "local,remote";
> > > }
> > >
> > > so at a method level, you can use local,remote or both. but, in
>LocalInterfaceSubTask.matchesGenerationRules we check for
> > >
> > > if( ( generate != null ) && ( generate.indexOf( "local" ) == -1 ) )
> > >
> > > so we have a little inconsistancy here.
> > >
> > > What do people prefer? By the sounds of it David prefers "both" and Ara
>"local,remote" (o: it wouldn't be too hard to support
> > > both "both" and "local,remote", but the code needs a little refactoring there (I
>can make time for this tonight if we agree on
> it
> > > today).
> > >
> > > thoughts?
> > >
> > > cheers
> > > dim
> > >
> > > ps - Ara, I got Jerome's stuff just before I left for work this morning, and
>will get that in tonight as well.
> > >
> > > ----- Original Message -----
> > > From: "Ara Abrahamian" <[EMAIL PROTECTED]>
> > > To: "'David Budworth'" <[EMAIL PROTECTED]>;
><[EMAIL PROTECTED]>
> > > Sent: Thursday, January 31, 2002 8:11 AM
> > > Subject: RE: [Xdoclet-devel] ejb:bean view-type question
> > >
> > >
> > > > > I'm working on making the ejb:bean tags inheritable (and fixing all
> > > > > sorts of problems with figuring out what's local/remote/both).
> > > > >
> > > > > question is, is:
> > > > > @ejb:bean view-type="local,remote"
> > > > >
> > > > > Still valid?
> > > >
> > > > AFAIK "both" is legal, not "remote,local".
> > > >
> > > > > But the validator doesn't split up the value to see if each one is in
> > > > > the valid options string. It just does an indexof into the valid
> > > > > values.
> > > >
> > > > This is wrong. Yes we need to stringtokenize it by ",".
> > > >
> > > > > So, do I fix getTagValue to attempt to parse the values? Or we just
> > > > > don't support multiple tag values like this? (oh please, oh please,
> > > > say
> > > > > we just don't support it anymore)
> > > >
> > > > it's not a good practice to split values like that, but I think it's
> > > > better to keep/correct it than remove it.
> > > >
> > > > Ara.
> > > >
> > > >
> > > > _________________________________________________________
> > > > Do You Yahoo!?
> > > > Get your free @yahoo.com address at http://mail.yahoo.com
> > > >
> > > >
> > > > _______________________________________________
> > > > Xdoclet-devel mailing list
> > > > [EMAIL PROTECTED]
> > > > https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
> > > >
_______________________________________________
Xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
