Howdy!

----- Original Message -----
From: Konstantin Priblouda <[EMAIL PROTECTED]>
Date: Thursday, April 11, 2002 4:31 pm
Subject: [Xdoclet-devel] xjavadoc RFE ( Aslak!!! )

> Hi all, 
> 
> xdoclet gui has some progress, so there is real
> need in tag/doc mutation
> 

It's starting to look good! I have an RFE too (Just looked it up, so to 
you who don't know: Request For Enhancement ;-)

Now there is

MyClass
  ejb
    @ejb:bean
      name
      type
      ...
    @ejb:data
      ...
    ...
  weblogic
    @weblogic:table-name

What if we just skip the Tag family node? It will make the navigation a 
bit shorter. Like this:
  
MyClass
  @ejb:bean
    name
    type
    ...
  @ejb:data
    ...
  ...
  @weblogic:table-name
  
Of course, that results in more sub nodes under classes/methods, but 
less clicking work. Anybody else have thoughts about this?

> I added methods to add/remove XTag to XDoc,
> but replacing tag content is suboptimal - first
> remove it and then create new one & add it
> to xdoc. 
> 

Why didn't you just make addTag(String,String) public? Would that 
suffice? Also keep in mind that XDoc stores references to XTags in Map 
_tagMap, XTag[] _tag *and* _allTags (because of various optimisation 
techniques). Your new addTag method doesn't respect that and probably 
messes up the internal state.

IMO it isn't anybody else's business to create XTag instances but XDoc 
(delegating to whatever TagFaxtory is installed). In other words: no 
XTag input parameters anywhere if we can avoid it. It makes the API 
easier to use.

I'm sure both Vincent (who has done the latest 
optimisations/refactorings in XDoc) and Ara (who requested the 
TagFactory concept some months ago because of his xtags ideas (which I 
still haven't quite grasped)) also have some viewpoints.

> Why not support direct tag content change with string
> ( and maybe reparsing it on the fly )?
> 

Have you tried XDoc.updateTagValue() ? The intention was that it should 
do the job. It isn't used by XDoclet, so it hasn't been well tested, 
but there are some tests I believe in XJavaDocTest that uses it.

> 
> Anyway. Now editing adding & removing of unknown
> ( by xtags ) tags works and rocks
> 

If you continue at the same speed as you have for the last weeks, when 
do you think we have something usable? It would be great to have it 
stable for the next XDoclet release. We can try to attract IDE plugin 
authors at that time.

> regards,
> 
> =====
> Konstantin Priblouda ( ko5tik )    Freelance Software developer
> < http://www.pribluda.de > < play java games -> http://www.yook.de >
> < render charts online -> http://www.pribluda.de/povray/ >
> 
> __________________________________________________
> Do You Yahoo!?
> Yahoo! Tax Center - online filing with TurboTax
> http://taxes.yahoo.com/
> 
> _______________________________________________
> Xdoclet-devel mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
> 


_______________________________________________
Xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to