> Howdy! Howdy Yo!
> > I added methods to add/remove XTag to XDoc, > > but replacing tag content is suboptimal - first > > remove it and then create new one & add it > > to xdoc. > > > > Why didn't you just make addTag(String,String) public? Would that > suffice? Also keep in mind that XDoc stores references to > XTags in Map > _tagMap, XTag[] _tag *and* _allTags (because of various optimisation > techniques). Your new addTag method doesn't respect that and probably > messes up the internal state. Yes be careful, lot of map everywhere that cache, I am a bit disappointed I did not name them better :( They are mainly in Xtag and Xdoc. > > IMO it isn't anybody else's business to create XTag instances > but XDoc > (delegating to whatever TagFaxtory is installed). In other words: no > XTag input parameters anywhere if we can avoid it. It makes the API > easier to use. > > I'm sure both Vincent (who has done the latest > optimisations/refactorings in XDoc) and Ara (who requested the > TagFactory concept some months ago because of his xtags ideas > (which I > still haven't quite grasped)) also have some viewpoints. A question instead ;) When you add/update/remove Xtag and Xdoc, the underlying file is changed magically ? > > > Why not support direct tag content change with string > > ( and maybe reparsing it on the fly )? > > > > Have you tried XDoc.updateTagValue() ? The intention was that > it should > do the job. It isn't used by XDoclet, so it hasn't been well tested, > but there are some tests I believe in XJavaDocTest that uses it. > > > > > Anyway. Now editing adding & removing of unknown > > ( by xtags ) tags works and rocks > > > > If you continue at the same speed as you have for the last > weeks, when > do you think we have something usable? It would be great to have it > stable for the next XDoclet release. We can try to attract IDE plugin > authors at that time. > It really looks fantastic, version 1.2 will be amazing really ! Vincent _______________________________________________ Xdoclet-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
