Konstantin Priblouda wrote:
> --- Marcin Zajaczkowski <[EMAIL PROTECTED]> wrote:
> 
>> Sure, thanks for point it out.
>> I added check if classTag is null and only then
>> classTag is fetched from 
>> class. That works properly.
> 
> You should iterate over getClassTags ( you like
> to catch all of them ;) ) - see how this is done with
> queries / columns . There is plenty of examples.

In HibernateMappingPlugin.jelly I have:

<j:forEach var="classTag" 
items="${metadata.getTagsByName('hibernate.class')}">
<j:import uri="/Class.jelly" inherit="true"/>
</j:forEach>

In Class.jelly:

<j:if test="${classTag == null}">
<j:set var="classTag" value="${class.getTagByName('hibernate.class')}"/>
</j:if>
(in fact hose line could be removed in current 
HibernateMappingPlugin.jelly configuration).

Do you think it should be better to move responsibility for iterating to 
Class.jelly and put there class,getTagsByName('hibernate.class') in a 
foreach loop?


>> Btw, is there a simply way to add an empty line in
>> .hbm?
(...)
> Usually nobody ever looks into hbm.xml except case of
> emergency or debugging plugin ;)
> ( that's puprose of this plugin )

Probably you are right. In my last project I was writing .hbm by hand. 
Maybe it's because of that.

> Yes, of course. Contributions / patches / maven gurus
> are always welcome. There is never enough manpower - 
> and most of us also have to do daily jobs 
> (some of them are hapy - like me - that I can 
> sell my work on xdoclet to my customers) 

I use xdoclet in my full time job and that feature would be useful in my 
current project. I would be happy having an ability to return my changes 
back into community.
I have my open source project as well and try to support (in various 
form) other interesting project.


Regards
Marcin


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
xdoclet-plugins-interest mailing list
xdoclet-plugins-interest@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xdoclet-plugins-interest

Reply via email to