--- Marcin Zaj±czkowski <[EMAIL PROTECTED]> wrote:

> Konstantin Priblouda wrote:
> > --- Marcin Zajaczkowski <[EMAIL PROTECTED]> wrote:
> > 
> >> Sure, thanks for point it out.
> >> I added check if classTag is null and only then
> >> classTag is fetched from 
> >> class. That works properly.
> > 
> > You should iterate over getClassTags ( you like
> > to catch all of them ;) ) - see how this is done
> with
> > queries / columns . There is plenty of examples.
> 
> In HibernateMappingPlugin.jelly I have:
> 
> <j:forEach var="classTag" 
>
items="${metadata.getTagsByName('hibernate.class')}">
> <j:import uri="/Class.jelly" inherit="true"/>
> </j:forEach>
> 
> In Class.jelly:
> 
> <j:if test="${classTag == null}">
> <j:set var="classTag"
> value="${class.getTagByName('hibernate.class')}"/>
> </j:if>
> (in fact hose line could be removed in current 
> HibernateMappingPlugin.jelly configuration).

Yes it could. 

> Do you think it should be better to move
> responsibility for iterating to 
> Class.jelly and put there
> class,getTagsByName('hibernate.class') in a 
> foreach loop?

It is better to keep iteration outside - like other
stuff is done. ( Modularity )

You should also keep in mind, that nested classes
are there too -  this should be expanded to them
/( they also could have versions / entities ) 




> Probably you are right. In my last project I was
> writing .hbm by hand. 
> Maybe it's because of that.

Not that funny...



regards,

----[ Konstantin Pribluda http://www.pribluda.de ]----------------
Still using XDoclet 1.x?  XDoclet 2 is released and of production quality.
check it out: http://xdoclet.codehaus.org


 
____________________________________________________________________________________
Bored stiff? Loosen up... 
Download and play hundreds of games for free on Yahoo! Games.
http://games.yahoo.com/games/front

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
xdoclet-plugins-interest mailing list
xdoclet-plugins-interest@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xdoclet-plugins-interest

Reply via email to