Mike,

we're in the middle of refactorings atm, but I'll look to incorporate your
changes when we get them back on the main branch of cvs.

btw - this will of course not apply to ejb 2 cmp model which requires
abstract get/set methods...

cheers
dim

On Fri, 19 Oct 2001, Mike Cannon-Brookes wrote:

> > > (I just delved into the WebWork codebase for 10 minutes, but
> > it's very hard
> > > to get a handle on what does what in the generation process ;))
> >
> > essentially there are two types of templates, per class, and per run.  The
> > entitycmp.j is obviously a per class.  things like ejb-jar_xml.j are per
> > run...
> 
> Noted
> 
> > > Having said that, I just got Dmitri's email and tried messing
> > with purely
> > > tags in the template - lo and behold, powerful new XDoclet features! ;)
> >
> > (o:  thats the way!
> 
> Just added some more, see other email.
> 
> > > I've prefixed my modifications with <NEW> rather than
> > <XDoclet>, tell me if
> > > you think this will fuck anything up ;)
> >
> > at a glance, looks ok...
> 
> Great!
> 
> > > wow - I can feel the power, four or five changes and IMHO
> > XDoclet will not
> > > only generate abstract methods, all other non abstract methods
> > are delegated
> > > to parent class! ;)
> > >
> > > Here's an example generated non-abstract getter / setter pair:
> > >
> > >    public java.util.Locale getLocale()
> > >    {
> > >           return super.getLocale();
> > >    }
> > >
> > >    public void setLocale( java.util.Locale locale )
> > >    {
> > >           super.setLocale(locale);
> > >
> > >       makeDirty();
> > >    }
> >
> > so this came out of your changes?  Have you also tried it with code that
> > follows the usual XDoclet pattern of declaring abstract methods?
> 
> Yep, this is generated from a non abstract method. Abstract methods generate
> as normal (as before). This bean has abstract and non abstract methods (ie
> some fields in the super class, some in the generated subclass)
> 
> > > IMHO it should still makeDirty() so I left that in. Also this does not
> > > create a field in the subclass, but it does still generate all fields
> > > (superclass and generated) in ejb-jar.xml and dataobjects.
> >
> > yes, definately leave it in.
> 
> Done.
> 
> > > Again - wow, I love this project more and more ;)
> >
> > (o:  join the club....
> 
> ;)
> 
> -mike
> 
> 
> Mike Cannon-Brookes :: [EMAIL PROTECTED]
> 
> Atlassian :: http://www.atlassian.com
>      Supporting YOUR J2EE World
> 
> 
> 
> _______________________________________________
> Xdoclet-user mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/xdoclet-user
> 


_______________________________________________
Xdoclet-user mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-user

Reply via email to