Wei Liu writes ("[OSSTEST PATCH 05/16] mg-debian-installer-update-all: put
quotes around arguments"):
> Signed-off-by: Wei Liu <wei.l...@citrix.com>
...
> suite=$1
> arch=$2
> -packages="$3"
> +packages=$3
Not sure why this needless style change, but if you did it
deliberately I don't really mind...
> site=http://ftp.debian.org/debian/
> sbase=$site/dists/$suite
> diff --git a/mg-debian-installer-update-all b/mg-debian-installer-update-all
> index d88ebf5..d590b2b 100755
> --- a/mg-debian-installer-update-all
> +++ b/mg-debian-installer-update-all
> @@ -31,5 +31,5 @@ fws=`getconfig DebianNonfreeFirmware`
> arches="arm64 armhf amd64 i386"
>
> for arch in $arches ; do
> - ./mg-debian-installer-update $suite $arch $fws
> + ./mg-debian-installer-update "$suite" "$arch" "$fws"
> done
This hunk LGTM. Although the "" around $suite and $arch are
unnecessary I don't really mind them.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
