Wei Liu writes ("[OSSTEST PATCH 10/16] ts-debian-fixup: remove extra= before
appending our own"):
> The original extra= was not removed, so there were two extra= in the
> resulting config file.
What is the original extra= ? Why should we not combine them ?
> It wasn't a problem for xl because the second extra= took precedence.
> However libvirt tests would only pick up the first extra= -- they
> worked by chance.
That's odd. Is this to do with the xl -> libxl config converter ?
It seems to me that that converter should interpret xl config files
the same way xl does. (Also xm did the same: last setting wins.)
>
> +
> + $cfg =~ s/^extra.*//mg;
> $cfg .= "\nextra='$extra'\n";
Also, accidental whitespace change.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
