On 25.03.2025 15:20, Andrew Cooper wrote:
> On 25/03/2025 12:51 pm, Jan Beulich wrote:
>> malloc(), when passed zero size, may return NULL (the behavior is
>> implementation defined).
>
> More importantly, this is the Musl behaviour, so is how ~most of Gitlab
> CI behaves.
>
>> Extend the ->gov_num check to the other two
>> allocations as well.
>
> I'm not sure what you mean by this. Only one of these hunks has a
> ->gov_num check.
Not sure I see a better way of wording this: What I mean to say is that
the ->gov_num check that there is already is being replicated (with "gov"
replaced accordingly) to the other two places where similar allocations
happen. Maybe simply s/Extend/Mirror" would already help?
>> Don't chance then actually using a NULL in
>> print_cpufreq_para().
>>
>> Fixes: 75e06d089d48 ("xenpm: add cpu frequency control interface, through
>> which user can")
>> Signed-off-by: Jan Beulich <jbeul...@suse.com>
>
> The code change looks ok, so Acked-by: Andrew Cooper
> <andrew.coop...@citrix.com> but I'd prefer a clarified commit message.
Thanks.
Jan
