On 25.03.2025 15:30, Jan Beulich wrote: > On 25.03.2025 15:20, Andrew Cooper wrote: >> On 25/03/2025 12:51 pm, Jan Beulich wrote: >>> malloc(), when passed zero size, may return NULL (the behavior is >>> implementation defined). >> >> More importantly, this is the Musl behaviour, so is how ~most of Gitlab >> CI behaves. >> >>> Extend the ->gov_num check to the other two >>> allocations as well. >> >> I'm not sure what you mean by this. Only one of these hunks has a >> ->gov_num check. > > Not sure I see a better way of wording this: What I mean to say is that > the ->gov_num check that there is already is being replicated (with "gov" > replaced accordingly) to the other two places where similar allocations > happen. Maybe simply s/Extend/Mirror" would already help?
Oh, and to clarify: The ->gov_num check mentioned isn't the one visible in one of the hunks. It's entirely outside of patch context. It was put there (for [now] questionable reasons by the HWP work). Jan