On 29.04.2025 13:52, Mykyta Poturai wrote:
> @@ -75,6 +76,11 @@ static int __init acpi_pci_init(void)
> }
> #endif
>
> +bool arch_pci_device_physdevop(void)
> +{
> + return iommu_enabled;
> +}
I'm not an Arm maintainer, but if I was, I'd demand that a clarifying comment
was added here.
> --- a/xen/arch/x86/include/asm/pci.h
> +++ b/xen/arch/x86/include/asm/pci.h
> @@ -67,4 +67,9 @@ static inline bool pci_check_bar(const struct pci_dev *pdev,
> return is_memory_hole(start, end);
> }
>
> +static always_inline bool arch_pci_device_physdevop(void)
I see not particular reason to use always_inline here; you don't do so ...
> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -79,6 +79,11 @@ static inline bool is_pci_passthrough_enabled(void)
> return false;
> }
>
> +static inline bool arch_pci_device_physdevop(void)
... here either.
I further notice that you didn't adjust the "reset" sub-op handling, despite
my earlier hint in that direction. Looking at the commit message, you only
mention PHYSDEVOP_pci_device_add anyway. I think all three need mentioning
there, which would then (hopefully) clarify what the deal is with
PHYSDEVOP_pci_device_reset.
Jan
