On 21.04.2025 09:37, Penny Zheng wrote: > Remove all "depends on !PV_SHIM_EXCLUSIVE" (also the functionally > equivalent "if !...") in Kconfig file, since negative dependancy will badly > affect allyesconfig. > This commit is based on "x86: provide an inverted Kconfig control for > shim-exclusive mode"[1]
Recall me asking to avoid wording like "This commit" in commit messages? Also personally I consider "is based on" ambiguous: It could also mean the one here needs to go on top of that other one. It's not entirely clear to me what kind of (relevant) information you're trying to convey with this sentence. Surely you didn't really need to even look at that patch of mine to find all the !PV_SHIM_EXCLUSIVE; that's a matter of a simply grep. > --- > xen/arch/x86/Kconfig | 4 ---- > xen/arch/x86/hvm/Kconfig | 1 - > xen/drivers/video/Kconfig | 4 ++-- > 3 files changed, 2 insertions(+), 7 deletions(-) With the changes here, what does this mean for the in-tree shim build, or any others using xen/arch/x86/configs/pvshim_defconfig as the basis? You aren't altering that file, so I expect the binary produced will change significantly (when it shouldn't, unless explicitly stated otherwise in the description, which may be warranted for SHADOW_PAGING). Jan
