On 30.04.2025 17:20, Jan Beulich wrote: > On 21.04.2025 09:37, Penny Zheng wrote: >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -581,4 +581,15 @@ config BUDDY_ALLOCATOR_SIZE >> Amount of memory reserved for the buddy allocator to serve Xen heap, >> working alongside the colored one. >> >> +menu "Supported hypercall interfaces" >> + visible if EXPERT >> + >> +config SYSCTL >> + bool "Enable sysctl hypercall" >> + default y > > Oh, and - just to re-iterate what I said earlier in the context of another > patch: > Imo you would better introduce the option without prompt (simply "defbool y"), > and make it user selectable only in the final patch. That'll eliminate the > need > for transient "#ifdef CONFIG_SYSCTL", i.e. reduce overall code churn.
Moving further through the series I noticed that omitting the prompt here will have an effect on the shim then - it'll be transiently (until the final patch of the series) be built with all of the sysctl code again. I think that's tolerable as long as in the final patch that is then being "cured" again. But it of course needs calling out, to make people explicitly aware. Jan
