Hi Julien, > On 6 May 2025, at 14:51, Julien Grall <jul...@xen.org> wrote: > > Hi Luca, > > On 06/05/2025 13:56, Luca Fancellu wrote: >>>> +/* >>>> + * Creates a pr_t structure describing a protection region. >>>> + * >>>> + * @base: base address as base of the protection region. >>>> + * @limit: exclusive address as limit of the protection region. >>>> + * @attr: attribute index for the memory type. >>>> + * @return: pr_t structure describing a protection region. >>>> + */ >>>> +extern pr_t pr_of_xenaddr(paddr_t base, paddr_t limit, unsigned int >>>> attr_idx); >>> here. Please don't use extern in prototypes. It's not needed. >> I see we have a mixed usage of this in arch/arm and it’s not documented to >> do otherwise >> in the code style, in this case I would prefer to be explicit unless it’s a >> strong objection on your side, >> let me know. > > Old Arm code is using "extern". But new code should avoid it for prototypes.
ok I see, I’ll drop it then. Cheers, Luca
