On 20.11.2025 10:58, Roger Pau Monne wrote: > The vector will be targeting a single CPU at a time, so passing a mask is > not needed. Simplify the interface and adjust callers to make use of it.
Considering the two callers we have, and considering the function is __init, do we need the function parameter at all? Can't we uniformly use the BSP? > --- a/xen/arch/x86/hpet.c > +++ b/xen/arch/x86/hpet.c > @@ -352,7 +352,7 @@ static int __init hpet_setup_msi_irq(struct > hpet_event_channel *ch) > * Technically we don't want to bind the IRQ to any CPU yet, but we need > to > * specify at least one online one here. Use the BSP. > */ > - ret = bind_irq_vector(ch->msi.irq, HPET_BROADCAST_VECTOR, cpumask_of(0)); > + ret = bind_irq_vector(ch->msi.irq, HPET_BROADCAST_VECTOR, 0); Irrespective of the remark above, the comment then will want re-wording some, too. Jan
