On 03/31/2017 07:47 AM, Jan Beulich wrote:
On 29.03.17 at 16:23, <julien.gr...@arm.com> wrote:
On 27/03/17 09:40, Wei Chen wrote:
@@ -154,8 +155,12 @@ static int __apply_alternatives_multi_stop(void *unused)
int ret;
struct alt_region region;
mfn_t xen_mfn = _mfn(virt_to_mfn(_start));
- unsigned int xen_order = get_order_from_bytes(_end - _start);
+ unsigned int xen_size = _end - _start;
I didn't notice it on the previous reviews. xen_size should technically
be paddr_t.
It is more for consistency than a real bug as the result _end - _start
will unlikely ever be > 4GB. I think Stefano should be able to fix on
commit. So no need to resend the patch.
Hmm, this mostly addresses one of the two complaints I was going
to make (pushing a patch which didn't go via xen-devel).
Actually, I was expected the patch to be fixed up on commit and not seen
a separate commit. I am not sure why it has been done like that... and
the commit title does not make that much sense.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
