Hi Stefano,
On 15/06/2017 23:31, Stefano Stabellini wrote:
On Tue, 13 Jun 2017, Julien Grall wrote:
Add a new helper clear_table to clear a page table entry and invalidate
the cache.
Signed-off-by: Julien Grall <julien.gr...@arm.com>
---
xen/arch/arm/mm.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 082c872c72..b4ff777b55 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -529,6 +529,13 @@ void __init remove_early_mappings(void)
extern void relocate_xen(uint64_t ttbr, void *src, void *dst, size_t len);
+/* Clear a translation table and clean & invalidate the cache */
+static void clear_table(void *table)
This could be a static inline. In any case:
I see you already committed. I see very limited use here for static
inline as this function might quite big (clear_page and
clean_and_invalidate_dcache_va_range). The compiler is in better
position to decide what to do than us.
IHMO, static inline should only be used in header and very small
function (basically just checking a condition).
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
