On Tue, Aug 22, 2017 at 03:51:02PM +0100, Paul Durrant wrote: > Legacy emulators use the 'default' IOREQ server which has slightly > different semantics than other, explicitly created, IOREQ servers. > > Because of this, most of the initialization and teardown code needs to > know whether the server is default or not. This is currently achieved > by passing an is_default boolean argument to the functions in question, > whereas this argument could be avoided by adding a field to the > hvm_ioreq_server structure which is also passed as an argument to all > the relevant functions. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com>
This looks fine, I've also seen that there's a hvm_domain.default_ioreq_server, which is used in a bunch of loops in the file like: if ( s == d->arch.hvm_domain.default_ioreq_server ) AFAICT those could also be replaced with s->is_default. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
