> -----Original Message----- > From: Roger Pau Monne > Sent: 24 August 2017 17:22 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: xen-de...@lists.xenproject.org; Andrew Cooper > <andrew.coop...@citrix.com>; Jan Beulich <jbeul...@suse.com> > Subject: Re: [Xen-devel] [PATCH v2 REPOST 08/12] x86/hvm/ioreq: move > is_default into struct hvm_ioreq_server > > On Tue, Aug 22, 2017 at 03:51:02PM +0100, Paul Durrant wrote: > > Legacy emulators use the 'default' IOREQ server which has slightly > > different semantics than other, explicitly created, IOREQ servers. > > > > Because of this, most of the initialization and teardown code needs to > > know whether the server is default or not. This is currently achieved > > by passing an is_default boolean argument to the functions in question, > > whereas this argument could be avoided by adding a field to the > > hvm_ioreq_server structure which is also passed as an argument to all > > the relevant functions. > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > This looks fine, I've also seen that there's a > hvm_domain.default_ioreq_server, which is used in a bunch of loops in the > file like: > > if ( s == d->arch.hvm_domain.default_ioreq_server ) > > AFAICT those could also be replaced with s->is_default.
Yes, they should be. Thanks for spotting that. Cheers, Paul > > Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
