>>> On 09.11.17 at 12:31, <roger....@citrix.com> wrote: > On Thu, Nov 09, 2017 at 03:49:23PM +0530, Bhupinder Thakur wrote: >> +static int ns16550_init_dt(struct ns16550 *uart, >> + const struct dt_device_node *dev) >> +{ >> + return -EINVAL; >> +} >> +#endif >> + >> +#ifdef CONFIG_ACPI >> +#include <xen/acpi.h> > > Please place the include at the top of the file, together with the > other ones.
I disagree here, at least as long as that header isn't itself expanding to nothing (or only stubs) when !CONFIG_ACPI. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel