On 24/03/2015 15:07, Robert VanVossen wrote:
Hello Julien,
Hello Robert,
On 3/23/2015 5:53 PM, Julien Grall wrote:
But don't we need to handle the failure of attach_dev differently based on which
fails? If the attach_dev fails on a new iommu_domain, then the iommu_domain
should be destroyed. If it fails on a preexisting iommu_domain that is already
attached to another device, then you don't want to destroy the iommu_domain.
It should be covered by
if (failed && atomic == 0)
destroy iommu_domain.
If you prefer to keep the 2 possible case separate, I would still like
to have a separate helper to get the domain.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel