On 09/12/16 10:49, Bhupinder Thakur wrote:
Hi Julien,
Hi Bhupinder,
On 6 December 2016 at 21:14, Julien Grall <julien.gr...@arm.com> wrote:
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -789,7 +789,8 @@ void __init start_xen(unsigned long
boot_phys_offset,
gic_init();
- p2m_vmid_allocator_init();
+ if ( p2m_vmid_allocator_init() != 0 )
+ panic("Could not allocate VMID bitmap space");
I am not sure why we have to initialize the VMID allocator far before
setting up the stage-2 translation (see call setup_virt_paging).
Overall, VMID are part of stage-2 subsystem. So I think it would be
better to move this call in setup_virt_paging.
With that you could take advantage of the for_each_online loop in
setup_virt_paging and avoid to have go through again all CPUs.
So what I would like to see is:
- Patch #1: move p2m_vmid_allocator_init in setup_virt_paging
- Patch #2: Add support for 16 bit VMIDs
I believe the 2nd patch should be based on the first patch. So they
should be applied in that order only. Should I send these two patches
as a series like [patch 1/2] and [patch 2/2]?
That's right.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
