On 15/12/2016 17:14, Bhupinder Thakur wrote:
Hi Julien,
Hi Bhupinder,
I did not send the 1st patch in the series as there is no change in
the first patch since the last one I sent. I understood from your last
mail that I need not send the patch again if there is no change.
You misunderstood what I said:
"No need to resend this series if there are no other comments."
This series is composed of 2 patches. So if you modified one patch in
the series you have to resend all the patches.
There are an exceptions when a committer has applied a part of the
series. In this case, you only have to resend those that haven't been
committed.
In the case of this series, the first patch was not committed. So you
have to send the 2 patches.
Should I send it again after updating the version as 5? Should I add
the reviewed-by tag in the first patch in the series?
The reviewed-by tag has to be carried across all the version unless the
patch has been heavily modified or the reviewer explicitly asked to
withdraw.
My comment on the previous version was only advice for the future on the
netiquette :).
I would prefer if you resend the series as the committer may not notice
that there was a first patch.
You don't need to bump the version (i.e v5 -> v6), instead add "RESEND"
in the tag:
[XEN VMID RESEND v5...]
If you have any doubt how to proceed, feel free to ask it :).
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel