>>> On 22.02.18 at 11:51, <andrew.coop...@citrix.com> wrote: > as-insn-check mutates the passed-in flags. Rename it to as-insn-add, in line > with cc-option-add. Update all callers.
I'm not convinced - cc-option-add makes relatively clear that something is being added to the options passed to CC. If I take as-insn-add this way, the macro would need to add an insn to the AS invocation. While I agree as-insn-check doesn't make clear that it adds any options, I still find this less misleading than the suggested new name. Let's see what others think. Jan _______________________________________________ Xen-devel mailing list Xenemail@example.com https://lists.xenproject.org/mailman/listinfo/xen-devel