On 06.07.2021 09:37, Jan Beulich wrote:
> On 28.06.2021 13:52, Jan Beulich wrote:
>> If anything, a check covering a wider range of invalid M2P entries ought
>> to be used (e.g. VALID_M2P()). But since everything is fully under Xen's
>> control at this stage, simply remove the BUG_ON().
>>
>> Signed-off-by: Jan Beulich <[email protected]>
>
> I didn't expect this to be controversial, so may I please ask for an ack
> (or otherwise)?
To be quite honest, I find it very strange that even simple changes like
this one sit un-responded to for months. This isn't the only example ...
Thanks, Jan
>> --- a/xen/arch/x86/pv/dom0_build.c
>> +++ b/xen/arch/x86/pv/dom0_build.c
>> @@ -815,7 +815,6 @@ int __init dom0_construct_pv(struct doma
>> page_list_for_each ( page, &d->page_list )
>> {
>> mfn = mfn_x(page_to_mfn(page));
>> - BUG_ON(SHARED_M2P(get_gpfn_from_mfn(mfn)));
>> if ( get_gpfn_from_mfn(mfn) >= count )
>> {
>> BUG_ON(compat);
>>
>
