On 25.11.2021 17:54, Julien Grall wrote: > On 25/11/2021 16:49, Julien Grall wrote: >> On 19/11/2021 10:21, Jan Beulich wrote: >>> From: Lasse Collin <lasse.col...@tukaani.org> >>> >>> It's good style. I was also told that GCC 7 is more strict and might >>> give a warning when such comments are missing. >>> >>> Suggested-by: Andrei Borzenkov <arvidj...@gmail.com> >>> Signed-off-by: Lasse Collin <lasse.col...@tukaani.org> > > Actually, any reason why there are some signed-off-by missing?
I often keep the author's, but drop ones which clearly got there only because of the path a patch has taken through trees. These aren't relevant imo when pulling over the change; I could as well take the email submission as my basis, after all, where just the single S-o-b would be there. Jan
