Hi,
On 25/11/2021 17:03, Jan Beulich wrote:
On 25.11.2021 17:54, Julien Grall wrote:
On 25/11/2021 16:49, Julien Grall wrote:
On 19/11/2021 10:21, Jan Beulich wrote:
From: Lasse Collin <lasse.col...@tukaani.org>
It's good style. I was also told that GCC 7 is more strict and might
give a warning when such comments are missing.
Suggested-by: Andrei Borzenkov <arvidj...@gmail.com>
Signed-off-by: Lasse Collin <lasse.col...@tukaani.org>
Actually, any reason why there are some signed-off-by missing?
I often keep the author's, but drop ones which clearly got there only
because of the path a patch has taken through trees.
This might be clear for you. For me, as a reviewer, I have to do extra
work to check whether you keeped the relevant signed-off-by.
These aren't
relevant imo when pulling over the change;
They are technically part of the "chain of approval".
I could as well take the
email submission as my basis, after all, where just the single S-o-b
would be there.
That's a fair point. That said, you took the commit-as-is from linus.git
so I think we ought to keep them.
Cheers,
--
Julien Grall
