On 26.11.2021 13:33, Andrew Cooper wrote: > --- a/xen/common/event_channel.c > +++ b/xen/common/event_channel.c > @@ -99,7 +99,8 @@ static xen_event_channel_notification_t __read_mostly > xen_consumers[NR_XEN_CONSUMERS]; > > /* Default notification action: wake up from wait_on_xen_event_channel(). */ > -static void default_xen_notification_fn(struct vcpu *v, unsigned int port) > +static void cf_check default_xen_notification_fn( > + struct vcpu *v, unsigned int port) > { > /* Consumer needs notification only if blocked. */ > if ( test_and_clear_bit(_VPF_blocked_in_xen, &v->pause_flags) )
Alongside this shouldn't you also annotate mem_paging_notification(), monitor_notification(), and mem_sharing_notification() right here (following how previous patches were organized)? I take that you're specifically leaving out anything in Arm code, no matter whether such annotations may gain a meaning at some point (not that I would know of any plans). Jan