Hi Andrew, > On 9 May 2022, at 13:24, Andrew Cooper <andrew.coop...@citrix.com> wrote: > > This is undefined behaviour, because there is no _spin_lock_cb() in a separate > translation unit (C11 6.7.4.11). > > Moreover, MISRA prohibits this construct because, in the case where it is well > defined, the compiler is free to use either implementation and nothing > prevents the two from being different. > > This function has external users, so drop the inline. > > Spotted by Eclair MISRA scanner. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Bertrand Marquis <bertrand.marq...@arm.com>
Cheers Bertrand