On 08.07.2022 16:54, Wei Chen wrote: > When NUMA initialization code is failed in scanning SRAT. It will > call bad_srat to set disable NUMA and clear relate data. But this > name is ACPI specific, we have moved generically usable NUMA codes > to common, bad_srat has came with these codes to common code. But > it's not reasonable for other NUMA implementations to implement a > fall back function named bad_srat. So in this patch, we rename > bad_srat to numa_bad. > > Signed-off-by: Wei Chen <wei.c...@arm.com> > --- > v1 -> v2: > 1. New in v2.
I think this wants to come before moving to common code. And I'd also like you to consider using e.g. numa_fw_bad() or numa_firmware_bad() to better reflect the original purpose. Jan