On 03.08.2022 15:27, Anthony PERARD wrote: > On Tue, Jun 14, 2022 at 05:22:48PM +0100, Anthony PERARD wrote: >> The get-fields.sh which generate all the include/compat/.xlat/*.h >> headers is quite slow. It takes for example nearly 3 seconds to >> generate platform.h on a recent machine, or 2.3 seconds for memory.h. >> >> Since it's only text processing, rewriting the mix of shell/sed/python >> into a single perl script make the generation of those file a lot >> faster. >> >> I tried to keep a similar look for the code, to keep the code similar >> between the shell and perl, and to ease review. So some code in perl >> might look weird or could be written better. >> >> No functional change, the headers generated are identical. >> >> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > > This patch have been on the mailing list for a little while now, could > it be acked then committed along with the previous one now?
Well, I would certainly be happy to ack it, but only on the basis of a suitable R-b by somebody else. My Perl is close to non-existing, so I can't sensibly review this myself. Jan
