Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeul...@suse.com>
> Sent: 2022年10月18日 22:08
> To: Wei Chen <wei.c...@arm.com>
> Cc: nd <n...@arm.com>; Andrew Cooper <andrew.coop...@citrix.com>; Roger Pau
> Monné <roger....@citrix.com>; Wei Liu <w...@xen.org>; George Dunlap
> <george.dun...@citrix.com>; Julien Grall <jul...@xen.org>; Stefano
> Stabellini <sstabell...@kernel.org>; xen-devel@lists.xenproject.org
> Subject: Re: [PATCH v6 5/6] xen/x86: move NUMA process nodes nodes code
> from x86 to common
>
> On 11.10.2022 13:17, Wei Chen wrote:
> > --- a/xen/arch/x86/numa.c
> > +++ b/xen/arch/x86/numa.c
> > @@ -46,6 +46,11 @@ bool arch_numa_disabled(void)
> > return acpi_numa < 0;
> > }
> >
> > +bool arch_numa_unavailable(void)
>
> __init ?
Yes, this function will only be called in an init function.
I will add it.
>
> > @@ -31,11 +46,334 @@ nodemask_t __read_mostly node_online_map = { { [0]
> = 1UL } };
> >
> > bool __ro_after_init numa_off;
> >
> > +const char *__ro_after_init numa_fw_nid_name = "NONAME";
>
> Didn't you mean to leave this at NULL for the DT case? (But yes, this
> way you avoid a conditional at every printk() using it.)
>
Yes.
> I'm also uncertain of "NOMAME" - personally I think e.g. "???" would
> be better, just in case a message actually is logged with this still
> un-overridden.
>
Ok, I will use "???" for this default value.
> > +bool __init numa_update_node_memblks(nodeid_t node, unsigned int
> arch_nid,
> > + paddr_t start, paddr_t size, bool
> hotplug)
> > + node_memblk_range[i].start = start;
> > + node_memblk_range[i].end = end;
> > +
> > + memmove(&memblk_nodeid[i + 1], &memblk_nodeid[i],
> > + (num_node_memblks - i) * sizeof(*memblk_nodeid));
> > + memblk_nodeid[i] = node;
> > +
> > + if ( hotplug ) {
>
> Nit: Placement of brace.
>
Ok.
> > --- a/xen/common/page_alloc.c
> > +++ b/xen/common/page_alloc.c
> > @@ -159,6 +159,8 @@
> > #define PGT_TYPE_INFO_INITIALIZER 0
> > #endif
> >
> > +paddr_t __read_mostly mem_hotplug;
>
> Not __ro_after_init?
I will add it.
Thanks,
Wei Chen
>
> Jan
