Hi Jan, > -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > >>> 4. Use %u instead of %d for nodeid_t and j in numa_setup print > >>> messages. > >> > >> The only instances of nodeid_t typed variable uses that I was able to > >> find are in dump_numa(). I guess you can leave them that way, but > >> strictly speaking %u isn't correct to use for nodeid_t (as it promotes > >> to int, not to unsigned int). > > > > Sorry for suddenly jumping into the discussion. Firstly thanks Jan for > > the review :)) > > > > I am a little bit confused here, nodeid_t is defined as: > > typedef u8 nodeid_t; > > > > so I think here %u should be probably fine (I may have missed > > something though)? > > %u is indeed "probably fine" (hence me saying that they can be left that > way), but from a strict language perspective it isn't: unsigned types > more narrow than "int" promote to "int", not "unsigned int" (and type > promotion kicks in when passing arguments to functions where only > ellipsis is specified, i.e. parameter type information isn't available).
Ah yes, sorry I should have thought deeper. Thanks for your detailed explanation. Kind regards, Henry > > Jan
