On Fri, 2022-10-21 at 09:06 +0200, Juergen Gross wrote:
> On 21.10.22 08:58, Juergen Gross wrote:
> > When the system is coming up after having been suspended,
> > restore_vcpu_affinity() is called for each domain in order to
> > adjust
> > the vcpu's affinity settings in case a cpu didn't come to live
> > again.
> >
> > The way restore_vcpu_affinity() is doing that is wrong, because the
> > specific scheduler isn't being informed about a possible migration
> > of
> > the vcpu to another cpu. Additionally the migration is often even
> > happening if all cpus are running again, as it is done without
> > check
> > whether it is really needed.
> >
> > As cpupool management is already calling cpu_disable_scheduler()
> > for
> > cpus not having come up again, and cpu_disable_scheduler() is
> > taking
> > care of eventually needed vcpu migration in the proper way, there
> > is
> > simply no need for restore_vcpu_affinity().
> >
> > So just remove restore_vcpu_affinity() completely.
> >
> > Fixes: 8a5d50dd0b04 ("xen: sched: simplify ACPI S3 resume path.")
>
> This Fixes: tag is wrong. It should be:
>
> Fixes: 8a04eaa8ea83 ("xen/sched: move some per-vcpu items to struct
> sched_unit")
>
Acked-by: Dario Faggioli <dfaggi...@suse.com>Thanks and Regards -- Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <<This happens because _I_ choose it to happen!>> (Raistlin Majere)
signature.asc
Description: This is a digitally signed message part
